HHH-19548 Upgrade to ByteBuddy 1.17.5 #10345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! This pull request appears to follow the contribution rules. › This message was automatically generated. |
yrodiere
force-pushed
the
HHH-19548
branch
2 times, most recently
from
8e9e49c to
5a13994
Compare
|
We have a test failure on JDK 26 specifically: https://develocity.commonhaus.dev/s/7e6ebrxmwnowq/tests/task/:hibernate-envers:test/details/org.hibernate.orm.test.envers.integration.lazy.LazyFieldsTest/testUpdate(SessionFactoryScope)?expanded-stacktrace=WyIwLTEtMiJd&top-execution=1 However, since the purpose of this PR is JDK 25 support, and I just added JDK 26 as a matter of course, I'd be inclined to merge, and investigate later. @beikov do you concur? |
|
Merging this is fine IMO, but AFAICT, JDK 26 simply has a bug in the ClassFile API, so it might be worth reporting this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hibernate.atlassian.net/browse/HHH-19548
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.